Skip to content

Update the DNS name for firmware presets #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the DNS name for firmware presets #4715

wants to merge 1 commit into from

Conversation

@blckmn
Copy link
Member

@blckmn blckmn commented Nov 29, 2025 •
edited by coderabbitai bot
Loading

The use of the location: https://api.betaflight.com/firmware-presets/ will remain, however in the future it may be served by a proxy for backwards compatibility, and the use of api.betaflight.com for more purposes other than presets.

Summary by CodeRabbit

  • Chores
    • Updated the official presets source URL to a new endpoint for improved service delivery.

✏️ Tip: You can customize this high-level summary in your review settings.

@blckmn
Update the DNS name for presets
f8a3703 
The use of the location: https://api.betaflight.com/firmware-presets/ will remain, however in the future it may be served by a proxy for backwards compatibility, and the use of api.betaflight.com for more purposes other than presets.
@blckmn blckmn added this to the 2025.12 milestone Nov 29, 2025
@blckmn blckmn self-assigned this Nov 29, 2025
@blckmn blckmn added this to 2025.12.0 Nov 29, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 29, 2025 •
edited
Loading

Walkthrough

The official Betaflight presets source URL is updated from https://api.betaflight.com/firmware-presets/ to https://presets.betaflight.com/firmware-presets/ in the _createOfficialSource function.

Changes

Cohort / File(s) Change Summary
URL Configuration Update
src/tabs/presets/SourcesDialog/SourcesDialog.js		 Updated official Betaflight presets source URL endpoint from api.betaflight.com to presets.betaflight.com

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file with a straightforward URL string literal change
  • No logic modifications or control flow alterations
  • No exported entity signature changes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks the structured format required by the template. It does not follow the repository's guidelines, provides no issue references, and doesn't explain the motivation or context adequately. Follow the repository's PR template structure, explain why this change is necessary, reference any related issues using 'Fixes #', and provide clearer context about the DNS change and future proxy plans.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the DNS name for firmware presets, which directly relates to the URL modification from api.betaflight.com to presets.betaflight.com.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5feaa87 and f8a3703.

📒 Files selected for processing (1)
  • src/tabs/presets/SourcesDialog/SourcesDialog.js (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-27T22:06:49.210Z 
Learnt from: haslinghuis
Repo: betaflight/betaflight-configurator PR: 4532
File: src/js/VirtualFC.js:234-234
Timestamp: 2025-06-27T22:06:49.210Z
Learning: In the betaflight-configurator codebase, the VirtualFC.js AUX_CONFIG array must stay synchronized with the betaflight firmware's msp_box.c definitions to ensure proper auxiliary mode functionality. Changes to mode names should follow the firmware source code even if it potentially breaks backward compatibility with saved presets.

Applied to files:

  • src/tabs/presets/SourcesDialog/SourcesDialog.js
🔇 Additional comments (1)
src/tabs/presets/SourcesDialog/SourcesDialog.js (1)

77-77: The URL verification approach in the review comment may be insufficient — the endpoint likely doesn't return a direct response to HEAD requests.

The web search indicates that https://presets.betaflight.com/firmware-presets/ returns 404 when accessed directly. However, this doesn't necessarily indicate a problem, as presets are served through JSON indices built by an indexer, not as a static HTML endpoint. A simple curl -sI test won't validate whether the new URL is properly configured at the application level.

To properly verify this change, you need to:

  1. Confirm that the application loads presets successfully after this change (via integration testing or manual testing with the configurator)
  2. Verify the JSON index endpoint is correctly mapped on presets.betaflight.com backend
  3. Search the codebase for any other hardcoded references to api.betaflight.com/firmware-presets that may need updating

The review comment's suggested verification scripts are technically sound but may not fully validate the change's correctness given how this API endpoint actually works.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

Preview URL: https://pr4715.betaflight-app-preview.pages.dev

@blckmn blckmn moved this to Done in 2025.12.0 Nov 29, 2025
@blckmn blckmn requested a review from haslinghuis November 29, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@blckmn blckmn

Labels

RN: IMPROVEMENT

Projects

2025.12.0
Status: Done

Milestone

2025.12

Development

Successfully merging this pull request may close these issues.

3 participants

@blckmn @haslinghuis @nerdCopter